New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Addressable instead of URI to decode #5726

Merged
merged 3 commits into from Jan 7, 2017

Conversation

Projects
None yet
3 participants
@jekyllbot
Contributor

jekyllbot commented Jan 5, 2017

PR automatically created for @pathawks.

Use Addressable instead of URI to decode
@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Jan 5, 2017

Member

Word in progress! Ready for review, I guess.

Fixes #4719

Member

pathawks commented Jan 5, 2017

Word in progress! Ready for review, I guess.

Fixes #4719

pathawks added some commits Jan 6, 2017

@oe oe added the do-not-merge label Jan 6, 2017

@@ -145,7 +145,8 @@ def self.escape_path(path)
# pct-encoded = "%" HEXDIG HEXDIG
# sub-delims = "!" / "$" / "&" / "'" / "(" / ")"
# / "*" / "+" / "," / ";" / "="
URI.escape(path, %r{[^a-zA-Z\d\-._~!$&'()*+,;=:@\/]}).encode("utf-8")
path = Addressable::URI.encode(path)
path.encode("utf-8").sub("#", "%23")

This comment has been minimized.

@pathawks

pathawks Jan 7, 2017

Member

Aside from escaping # (which I cannot understand), Addressable seems to perfectly fit our needs 👍

@pathawks

pathawks Jan 7, 2017

Member

Aside from escaping # (which I cannot understand), Addressable seems to perfectly fit our needs 👍

@pathawks pathawks removed the do-not-merge label Jan 7, 2017

@oe

oe approved these changes Jan 7, 2017

@oe

This comment has been minimized.

Show comment
Hide comment
@oe

oe Jan 7, 2017

Member

@jekyllbot: merge +minor

Member

oe commented Jan 7, 2017

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 214eedc into master Jan 7, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the pull/remove-deprecated branch Jan 7, 2017

jekyllbot added a commit that referenced this pull request Jan 7, 2017

@pathawks pathawks referenced this pull request Jan 7, 2017

Closed

Move away from Deprecated features. #4719

0 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment