Sort gems #5746
Merged
Sort gems #5746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashmaroli
requested changes
Jan 10, 2017
| s.add_runtime_dependency("jekyll-sass-converter", "~> 1.0") | ||
| s.add_runtime_dependency("jekyll-watch", "~> 1.1") | ||
| s.add_runtime_dependency("kramdown", "~> 1.3") |
There was a problem hiding this comment.
before: the whitespace after gem-name improved readability
after: it just looks weird..
suggestion: normalize whitespace and improve readability. 😃
ghost
approved these changes
Jan 10, 2017
|
@jekyllbot: merge +minor |
|
@quiltbag For future reference, this probably should have been |
|
@parkr okay! do we have a reference for those flags somewhere? |
|
@quiltbag 😄 General docs are here: http://jekyllrb.com/docs/maintaining/ and for this specifically, http://jekyllrb.com/docs/maintaining/merging-a-pull-request/#merging – no big deal, I just updated it in 2236889. |
|
@parkr thanks :o i didn't see that doc |
|
@quiltbag No problem at all! Feel free to reach out with any questions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
À la Rubocop.
/cc @jekyll/core