New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rubocop: Require consistent comma in multiline literals #5761

Merged
merged 1 commit into from Jan 13, 2017

Conversation

Projects
None yet
5 participants
@jekyllbot
Contributor

jekyllbot commented Jan 12, 2017

PR automatically created for @pathawks.

Rubocop: Require consistent comma in multiline literals

@pathawks pathawks requested a review from DirtyF Jan 12, 2017

@pathawks pathawks added the internal label Jan 12, 2017

@DirtyF

DirtyF approved these changes Jan 13, 2017

👍 no offenses detected.

@DirtyF DirtyF requested a review from parkr Jan 13, 2017

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jan 13, 2017

Member

Same change as @parkr did in github/pages-gem#383

Member

DirtyF commented Jan 13, 2017

Same change as @parkr did in github/pages-gem#383

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Jan 13, 2017

Member

@DirtyF I wonder what got me thinking about it 🤔 🤣

Member

pathawks commented Jan 13, 2017

@DirtyF I wonder what got me thinking about it 🤔 🤣

@parkr

parkr approved these changes Jan 13, 2017

😍

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jan 13, 2017

Member

@jekyllbot: merge +dev

Member

DirtyF commented Jan 13, 2017

@jekyllbot: merge +dev

@DirtyF DirtyF closed this Jan 13, 2017

@jekyllbot jekyllbot merged commit 76410d1 into master Jan 13, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the pull/consistent_comma branch Jan 13, 2017

jekyllbot added a commit that referenced this pull request Jan 13, 2017

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Jan 28, 2017

Member

Rubocop v0.47.1 now raises an offence against a hash previously ignored..
overzealous cop? or error on our side?

Member

ashmaroli commented Jan 28, 2017

Rubocop v0.47.1 now raises an offence against a hash previously ignored..
overzealous cop? or error on our side?

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jan 28, 2017

Member

We used the auto-correct feature here so probably an edge case that was fixed in the latest version of Rubocop.

Member

parkr commented Jan 28, 2017

We used the auto-correct feature here so probably an edge case that was fixed in the latest version of Rubocop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment