Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rubocop: Require consistent comma in multiline literals #5761

Merged
merged 1 commit into from
Jan 13, 2017
Merged

Rubocop: Require consistent comma in multiline literals #5761

merged 1 commit into from
Jan 13, 2017

Conversation

jekyllbot
Copy link
Contributor

PR automatically created for @pathawks.

Rubocop: Require consistent comma in multiline literals

@pathawks pathawks requested a review from DirtyF January 12, 2017 23:53
DirtyF
DirtyF approved these changes Jan 13, 2017
View reviewed changes
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 no offenses detected.

@DirtyF DirtyF requested a review from parkr January 13, 2017 00:06
@DirtyF
Copy link
Member

DirtyF commented Jan 13, 2017

Same change as @parkr did in github/pages-gem#383

@pathawks
Copy link
Member

@DirtyF I wonder what got me thinking about it 🤔 🤣

parkr
parkr approved these changes Jan 13, 2017
View reviewed changes
Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@DirtyF
Copy link
Member

DirtyF commented Jan 13, 2017

@jekyllbot: merge +dev

@DirtyF DirtyF closed this Jan 13, 2017
@jekyllbot jekyllbot merged commit 76410d1 into master Jan 13, 2017
@jekyllbot jekyllbot deleted the pull/consistent_comma branch January 13, 2017 00:41
jekyllbot added a commit that referenced this pull request Jan 13, 2017
@jekyllbot
Update history to reflect merge of #5761 [ci skip]
27ed815
@ashmaroli
Copy link
Member

Rubocop v0.47.1 now raises an offence against a hash previously ignored..
overzealous cop? or error on our side?

@parkr
Copy link
Member

parkr commented Jan 28, 2017

We used the auto-correct feature here so probably an edge case that was fixed in the latest version of Rubocop.

@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@DirtyF DirtyF DirtyF approved these changes

@parkr parkr parkr approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jekyllbot @DirtyF @pathawks @ashmaroli @parkr