Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump rubocop #5765

Merged
merged 4 commits into from
Jan 15, 2017
Merged

Bump rubocop #5765

merged 4 commits into from
Jan 15, 2017

Conversation

DirtyF
Copy link
Member

@DirtyF DirtyF commented Jan 14, 2017

  • upgrade to v0.46
  • refine rules for Rakefile, rake tasks and gemspec
  • rubocop -a

/cc @jekyll/core

@pathawks
Copy link
Member

What does Rubocop not like about our gemspec?

@ashmaroli
Copy link
Member

What does Rubocop not like about our gemspec?

@pathawks

  • This block has too many lines [29/25]
  • This line is too long [105/90]

@DirtyF
Copy link
Member Author

DirtyF commented Jan 15, 2017

@jekyllbot: merge +dev

@DirtyF DirtyF closed this Jan 15, 2017
@jekyllbot jekyllbot merged commit 057365a into master Jan 15, 2017
@jekyllbot jekyllbot deleted the bump-rubocop branch January 15, 2017 08:47
jekyllbot added a commit that referenced this pull request Jan 15, 2017
@jekyllbot
Update history to reflect merge of #5765 [ci skip]
becdcb5
@jekyll jekyll locked and limited conversation to collaborators Jul 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parkr parkr parkr approved these changes

Assignees
No one assigned
Labels
fix frozen-due-to-age internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@DirtyF @pathawks @ashmaroli @parkr @jekyllbot