New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop #5765

Merged
merged 4 commits into from Jan 15, 2017

Conversation

Projects
None yet
5 participants
@DirtyF
Member

DirtyF commented Jan 14, 2017

  • upgrade to v0.46
  • refine rules for Rakefile, rake tasks and gemspec
  • rubocop -a

/cc @jekyll/core

@DirtyF DirtyF added the internal label Jan 14, 2017

@parkr

parkr approved these changes Jan 15, 2017

@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Jan 15, 2017

Member

What does Rubocop not like about our gemspec?

Member

pathawks commented Jan 15, 2017

What does Rubocop not like about our gemspec?

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Jan 15, 2017

Member

What does Rubocop not like about our gemspec?

@pathawks

  • This block has too many lines [29/25]
  • This line is too long [105/90]
Member

ashmaroli commented Jan 15, 2017

What does Rubocop not like about our gemspec?

@pathawks

  • This block has too many lines [29/25]
  • This line is too long [105/90]
@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Jan 15, 2017

Member

@jekyllbot: merge +dev

Member

DirtyF commented Jan 15, 2017

@jekyllbot: merge +dev

@DirtyF DirtyF closed this Jan 15, 2017

@jekyllbot jekyllbot merged commit 057365a into master Jan 15, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the bump-rubocop branch Jan 15, 2017

jekyllbot added a commit that referenced this pull request Jan 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment