New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compress Website Sass output #6009

Merged
merged 2 commits into from Apr 25, 2017

Conversation

Projects
None yet
4 participants
@DirtyF
Member

DirtyF commented Apr 5, 2017

Suggested by @pathawks in #6008

@DirtyF DirtyF added the documentation label Apr 5, 2017

@DirtyF DirtyF requested a review from pathawks Apr 5, 2017

Show outdated Hide outdated rake/site.rake
@@ -47,7 +47,7 @@ namespace :site do
task :update_normalize_css do
Dir.chdir("#{docs_folder}/_sass") do
sh 'curl "https://necolas.github.io/normalize.css/latest/normalize.css" -o "normalize.scss"'
sh 'sass "normalize.scss":"_normalize.scss" --style compressed'
sh 'sass "normalize.scss":"_normalize.scss"'

This comment has been minimized.

@pathawks

pathawks Apr 6, 2017

Member

What is the purpose of this?

Why not:

sh 'curl "https://necolas.github.io/normalize.css/latest/normalize.css" -o "_normalize.scss"'
@pathawks

pathawks Apr 6, 2017

Member

What is the purpose of this?

Why not:

sh 'curl "https://necolas.github.io/normalize.css/latest/normalize.css" -o "_normalize.scss"'

This comment has been minimized.

@DirtyF

DirtyF Apr 6, 2017

Member

It seems that previously we used a Sass workflow, and now we rely entirely on GitHub Pages pipeline. We therefore can simplify here to the bare minimum, you're right.

Suggestion applied. 🖖

@DirtyF

DirtyF Apr 6, 2017

Member

It seems that previously we used a Sass workflow, and now we rely entirely on GitHub Pages pipeline. We therefore can simplify here to the bare minimum, you're right.

Suggestion applied. 🖖

Simplify update_normalize site task
Just copy the latest version to the Website Sass folder and let Jekyll handle the compression. 
props @pathawks
@pathawks

This comment has been minimized.

Show comment
Hide comment
@pathawks

pathawks Apr 6, 2017

Member

…as long as there isn't some reason I'm not thinking of to not do this

Member

pathawks commented Apr 6, 2017

…as long as there isn't some reason I'm not thinking of to not do this

@DirtyF DirtyF requested a review from parkr Apr 6, 2017

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 10, 2017

Member

This is automatically done in production - are you seeing different results on jekyllrb.com?

Member

parkr commented Apr 10, 2017

This is automatically done in production - are you seeing different results on jekyllrb.com?

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Apr 10, 2017

Member

@parkr https://jekyllrb.com/css/screen.css does not look compressed to me

Member

DirtyF commented Apr 10, 2017

@parkr https://jekyllrb.com/css/screen.css does not look compressed to me

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 25, 2017

Member

You're absolutely right! It defaults to :compact, which isn't the same.

Member

parkr commented Apr 25, 2017

You're absolutely right! It defaults to :compact, which isn't the same.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Apr 25, 2017

Member

@jekyllbot: merge +docs

Member

parkr commented Apr 25, 2017

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit d37f604 into jekyll:master Apr 25, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Apr 25, 2017

@DirtyF DirtyF deleted the DirtyF:sass-compressed branch Apr 25, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment