Compress Website Sass output #6009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pathawks
reviewed
Apr 6, 2017
rake/site.rake
Outdated
| @@ -47,7 +47,7 @@ namespace :site do | |||
| task :update_normalize_css do | |||
| Dir.chdir("#{docs_folder}/_sass") do | |||
| sh 'curl "https://necolas.github.io/normalize.css/latest/normalize.css" -o "normalize.scss"' | |||
| sh 'sass "normalize.scss":"_normalize.scss" --style compressed' | |||
| sh 'sass "normalize.scss":"_normalize.scss"' | |||
There was a problem hiding this comment.
What is the purpose of this?
Why not:
sh 'curl "https://necolas.github.io/normalize.css/latest/normalize.css" -o "_normalize.scss"'There was a problem hiding this comment.
It seems that previously we used a Sass workflow, and now we rely entirely on GitHub Pages pipeline. We therefore can simplify here to the bare minimum, you're right.
Suggestion applied. 🖖
Just copy the latest version to the Website Sass folder and let Jekyll handle the compression. props @pathawks
pathawks
approved these changes
Apr 6, 2017
|
…as long as there isn't some reason I'm not thinking of to not do this |
|
This is automatically done in production - are you seeing different results on jekyllrb.com? |
|
@parkr https://jekyllrb.com/css/screen.css does not look compressed to me |
|
You're absolutely right! It defaults to |
|
@jekyllbot: merge +docs |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested by @pathawks in #6008