New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow you to specify the rouge version via an environment variable for testing #6138

Merged
merged 1 commit into from Jun 15, 2017

Conversation

Projects
None yet
3 participants
@parkr
Member

parkr commented Jun 14, 2017

Should address @pathawks's comment here: #5230 (comment)

In a PR which bumps Rouge, you'd update the default to 2 and voila.

@parkr parkr added the internal label Jun 14, 2017

@parkr parkr changed the title from Allow you to specify the rouge version via an environemnt variable for testing to Allow you to specify the rouge version via an environment variable for testing Jun 14, 2017

@parkr parkr added the tests label Jun 14, 2017

@parkr parkr requested a review from pathawks Jun 14, 2017

@pathawks

❤️❤️❤️

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jun 15, 2017

Member

@jekyllbot: merge +dev

Member

parkr commented Jun 15, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 79b3f00 into master Jun 15, 2017

1 of 2 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@jekyllbot jekyllbot deleted the rouge-travis-matrix branch Jun 15, 2017

jekyllbot added a commit that referenced this pull request Jun 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment