Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow you to specify the rouge version via an environment variable for testing #6138

Merged
merged 1 commit into from
Jun 15, 2017

Conversation

parkr
Copy link
Member

@parkr parkr commented Jun 14, 2017

Should address @pathawks's comment here: #5230 (comment)

In a PR which bumps Rouge, you'd update the default to 2 and voila.

@parkr parkr added the internal label Jun 14, 2017
@parkr parkr changed the title Allow you to specify the rouge version via an environemnt variable for testing Allow you to specify the rouge version via an environment variable for testing Jun 14, 2017
@parkr parkr added the tests label Jun 14, 2017
@parkr parkr requested a review from pathawks June 14, 2017 21:25
Copy link
Member

@pathawks pathawks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️❤️❤️

@parkr
Copy link
Member Author

parkr commented Jun 15, 2017

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 79b3f00 into master Jun 15, 2017
@jekyllbot jekyllbot deleted the rouge-travis-matrix branch June 15, 2017 12:29
jekyllbot added a commit that referenced this pull request Jun 15, 2017
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants