New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small correction in documentation for includes #6193

Merged
merged 1 commit into from Jul 1, 2017

Conversation

Projects
None yet
5 participants
@kplattret
Member

kplattret commented Jul 1, 2017

When passing references to YAML files as parameter values the references shouldn't be added as an object, i.e. it shouldn't be wrapped in double curly brackets.

Small correction in documentation for includes
When passing references to YAML files as parameter values the references shouldn't be added as an object, i.e. it shouldn't be wrapped in double curly brackets.
@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 1, 2017

Member

This seems right to me. Great catch.

I'll try to test this out and ensure it works as intended before merging. If someone else wants to test this, feel free to add an approval to this PR.

Thank you!

Member

parkr commented Jul 1, 2017

This seems right to me. Great catch.

I'll try to test this out and ensure it works as intended before merging. If someone else wants to test this, feel free to add an approval to this PR.

Thank you!

@DirtyF

DirtyF approved these changes Jul 1, 2017

Tested it locally and it works as intended. Thanks.

@parkr

This comment has been minimized.

Show comment
Hide comment
@parkr

parkr Jul 1, 2017

Member

@jekyllbot: merge +site

Member

parkr commented Jul 1, 2017

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 2253b9d into jekyll:master Jul 1, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

jekyllbot added a commit that referenced this pull request Jul 1, 2017

@kplattret kplattret deleted the kplattret:patch-1 branch Jul 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment