Fix 1dc2bc74580060d4f00dd4a45e02a70574a56672 #6246
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @jekyll/stability |
parkr
reviewed
Jul 29, 2017
| @@ -22,7 +22,7 @@ def initialize(server, root, callbacks) | |||
|
|
|||
| def search_file(req, res, basename) | |||
| # /file.* > /file/index.html > /file.html | |||
There was a problem hiding this comment.
Can you illustrate what this change does by modifying this comment?
/.html > /file > /file.html?
|
Trying to grok the new behaviour but don't quite understand the intentioned difference here. Could you please provide an example? /cc the other PR which @envygeeks is fixing here #6231 |
|
Closing due to no response. Feel free to respond here and we can re-open. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That code violated the intention of this source, the intention of this source was to always serve html files before directories and only allow indexing in the case there is no clash.