New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add jekyll-pwa-plugin #6533

Merged
merged 3 commits into from Nov 9, 2017

Conversation

Projects
None yet
5 participants
@xiaoiver
Contributor

xiaoiver commented Nov 8, 2017

No description provided.

Show outdated Hide outdated docs/_docs/plugins.md Outdated

@DirtyF DirtyF added the site label Nov 8, 2017

@DirtyF

DirtyF approved these changes Nov 8, 2017

Cool plugin, will check it out. 🚀

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Nov 9, 2017

Member

@xiaoiver You might want to update the plugin's usage section. When i initially tried adding the gem and config block to my test site, bundle exec jekyll serve failed with an error..
(resumed properly after I manually copied the contents of your vendor/ to my site)

Note: This should ideally be a bug report in your repo, but the plugin is only at 0.0.1 .. bound to have issues..

Member

ashmaroli commented Nov 9, 2017

@xiaoiver You might want to update the plugin's usage section. When i initially tried adding the gem and config block to my test site, bundle exec jekyll serve failed with an error..
(resumed properly after I manually copied the contents of your vendor/ to my site)

Note: This should ideally be a bug report in your repo, but the plugin is only at 0.0.1 .. bound to have issues..

@xiaoiver

This comment has been minimized.

Show comment
Hide comment
@xiaoiver

xiaoiver Nov 9, 2017

Contributor

Hi @ashmaroli , in this plugin I want to copy two files(a polyfill & workbox) under /vendor to _site/js:

Dir.glob(File.expand_path('../vendor/**/*', __FILE__)) do |filepath_to_copy|
    basename = File.basename(filepath_to_copy)
    FileUtils.copy_file(filepath_to_copy, File.join(@site.dest, 'js', basename))

So in service worker generated, I can import these scripts correctly:
importScripts('#{@site.baseurl}/js/#{vendor_file}');

Maybe I make a wrong assumption that users put their scripts in /js.
Since I'm not very familiar with Ruby and Jekyll indeed, plz point it out if I make some mistakes.

Contributor

xiaoiver commented Nov 9, 2017

Hi @ashmaroli , in this plugin I want to copy two files(a polyfill & workbox) under /vendor to _site/js:

Dir.glob(File.expand_path('../vendor/**/*', __FILE__)) do |filepath_to_copy|
    basename = File.basename(filepath_to_copy)
    FileUtils.copy_file(filepath_to_copy, File.join(@site.dest, 'js', basename))

So in service worker generated, I can import these scripts correctly:
importScripts('#{@site.baseurl}/js/#{vendor_file}');

Maybe I make a wrong assumption that users put their scripts in /js.
Since I'm not very familiar with Ruby and Jekyll indeed, plz point it out if I make some mistakes.

@ashmaroli

This comment has been minimized.

Show comment
Hide comment
@ashmaroli

ashmaroli Nov 9, 2017

Member

@xiaoiver opened an issue ticket at your repo.. best, we continue there..

Member

ashmaroli commented Nov 9, 2017

@xiaoiver opened an issue ticket at your repo.. best, we continue there..

@DirtyF

This comment has been minimized.

Show comment
Hide comment
@DirtyF

DirtyF Nov 9, 2017

Member

@jekyllbot: merge +site

Member

DirtyF commented Nov 9, 2017

@jekyllbot: merge +site

@jekyllbot jekyllbot merged commit 0c25411 into jekyll:master Nov 9, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment