Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post: Jekyll 3.7.0 released #6634

Merged
merged 3 commits into from Jan 2, 2018
Merged

Post: Jekyll 3.7.0 released #6634

merged 3 commits into from Jan 2, 2018

Conversation

jekyllbot
Copy link
Contributor

@jekyllbot jekyllbot commented Dec 15, 2017

No description provided.

@parkr parkr mentioned this pull request Dec 15, 2017
3 tasks
@DirtyF DirtyF requested a review from a team December 15, 2017 17:42
@DirtyF DirtyF added the release Time to cut a new gem! label Dec 15, 2017
Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Some minor changes..

categories: [release]
---

We're happy to announce that Jekyll latest minor release is out before Christmas!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- announce that Jekyll latest minor release is out before Christmas!
+ announce that we've released a minor update before Christmas!


Here are a few of the latest gifts 🎁 from our contributors:

* LiveReload is available as an option during development: `bundle exec jekyll server --livereload`, no more manual page refresh. A big thanks to @awood for this feature and to @andreyvit, livereload author.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bundle exec jekyll serve --livereload
We've moved away from the server command since long..

👍 for crediting the JS author


> Ruby 2.2 is now under the state of the security maintenance phase, until the end of the March of 2018. After the date, maintenance of Ruby 2.2 will be ended. We recommend you start planning migration to newer versions of Ruby, such as 2.4 or 2.3. — [Ruby Core Team](https://www.ruby-lang.org/en/news/2017/12/14/ruby-2-2-9-released/)

We strongly encourage you to upgrade to at least Ruby 2.4 or even go with Ruby 2.5 that should be out in the coming days if you want to benefits from the latest language additions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommend at least Ruby 2.3 which won't be going EOL until March '19..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend != Require.

We are taking advantage of new language features whenever they can be use in a way that degrades gracefully; I think it is a Good Thing to recommend 2.4 👍

@@ -0,0 +1,31 @@
---
title: "Jekyll 3.7.0 Released"
description: "Jekyll 3.7.0 brings livereload, ."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- "Jekyll 3.7.0 brings livereload, ."
+ "Jekyll 3.7.0 brings LiveReload..!"

@DirtyF DirtyF force-pushed the pull/post-3.7.0-released branch 2 times, most recently from 0bba31f to b6e7f93 Compare December 15, 2017 21:11
@ashmaroli
Copy link
Member

The edited post looks good!!
Some nits about dates:

  • Can you please change the post date, post name, etc to be 2017-12-18 (the expected release date..). You can always preview it with the --future option 😉
  • The author-date and commit-date are way off on this..

github com_jekyll_jekyll_pull_6634_commits

@ashmaroli
Copy link
Member

ashmaroli commented Dec 17, 2017

@DirtyF please use emojis for the graphics in the post. Attached below is a screenshot of this post on latest Chrome on Windows:

@@ -0,0 +1,38 @@
---
title: "Jekyll 3.7.0 Released"
description: "Jekyll 3.7.0 brings livereload, a directory for your collections and much more…"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

capitalize LiveReload here!

---
title: "Jekyll 3.7.0 Released"
description: "Jekyll 3.7.0 brings livereload, a directory for your collections and much more…"
date: 2017-12-17 12:31:40 +0100
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this date needs to be updated


We strongly encourage you to upgrade to at least Ruby 2.4.x [like our friends at GitHub Pages](https://pages.github.com/versions/) or even go with Ruby 2.5 that should be out in the coming days.

:christmas_tree: A merry Christmas to all from the Jekyll team!
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, update this for new years

categories: [release]
---

We're happy to release a new minor update before Christmas!
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/before christmas/in time for the new year


We're happy to release a new minor update before Christmas!

Here are a few of the latest gifts :gift: from our contributors:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure whether this metaphor fits anymore

Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 Let's ship it! :shipit:

title: "Jekyll 3.7.0 Released"
description: "Jekyll 3.7.0 brings livereload, a directory for your collections and much more…"
date: 2017-12-17 12:31:40 +0100
author: dirtyf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DirtyF here

@DirtyF
Copy link
Member

DirtyF commented Jan 2, 2018

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit c3026bd into master Jan 2, 2018
@jekyllbot jekyllbot deleted the pull/post-3.7.0-released branch January 2, 2018 19:17
jekyllbot added a commit that referenced this pull request Jan 2, 2018
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age release Time to cut a new gem!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants