Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix passing multiline params to include tag when using the variable syntax #6858

Merged
merged 3 commits into from Mar 21, 2018
Merged

Fix passing multiline params to include tag when using the variable syntax #6858

merged 3 commits into from Mar 21, 2018

Conversation

ashmaroli
Copy link
Member

Fixes #6857

@ashmaroli ashmaroli added the fix label Mar 18, 2018
@ashmaroli ashmaroli requested review from pathawks and a team March 18, 2018 19:18
@parkr
Copy link
Member

parkr commented Mar 18, 2018

Needs a test! AFAIK, . should include \s?

@pathawks
Copy link
Member

. does not match newlines unless used in multiline mode (/m)

@ashmaroli
Copy link
Member Author

unless used in multiline mode (/m)

🤦‍♂️ of course..! /m is the better alternative..

@DirtyF
Copy link
Member

DirtyF commented Mar 21, 2018

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 8f3363e into jekyll:master Mar 21, 2018
jekyllbot added a commit that referenced this pull request Mar 21, 2018
@jekyllbot
Update history to reflect merge of #6858 [ci skip]
7d759f0
@ashmaroli ashmaroli deleted the include-var-newline branch March 22, 2018 03:28
@jekyll jekyll locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pathawks pathawks pathawks approved these changes

@Crunch09 Crunch09 Crunch09 approved these changes

Assignees
No one assigned
Labels
bug 🐛 fix frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing parameters to include-by-variable across multiple lines
6 participants
@ashmaroli @parkr @pathawks @DirtyF @Crunch09 @jekyllbot