Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Add whitespace control to LIQUID_TAG_REGEX #7015
referenced this pull request
May 15, 2018
@kylebarbour Thank you for opening the PR.
You may refer to #6724 to see what tests are currently in place to test this functionality. If it looks confusing to you, the following note should guide you:
All you need to do is (at minimum):
(Optional): Once you're comfortable with the tests, you can add and test more posts with various valid placement of the whitespace-control character.
If you still find it hard to add tests for this PR, feel free to inform so here.
@kylebarbour The tests look good.
The message to Jekyll Logger converts all "whitespace" to a "single space" character. Therefore,
So, IMO this should be in 2 separate calls:
Jekyll.logger.error "Error:", "This page's excerpt appears to contain a Liquid tag which couldn't be parsed" Jekyll.logger.error "", e.message
Disclaimer: The suggestion above has not been tested locally..
Since, I can't test locally, I'm not sure if Jekyll has to log