Make file name matcher check on base name of entry #7067
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am writing a textbundle plugin for jekyll. I found that If a folder in
_posts
named2018-06-09-Test.textbundle
, which can pass the matcher check, all files in the folder will pass the check no matter what name they have.That means all the png images in textbundle will tried to be read by Jekyll and we will see an error message for them. textbundle format also contains a json file which is not used by Jekyll but recognized as a Jekyll::Document.
I know having a folder in _posts folder and it’s name happened to pass the file name checker is not common, but file name checker is supposed to check a file’s name rather than it’s location. So I think it will be nice to fix it.