Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Sanity check with sassc gem #7288

Closed
wants to merge 1 commit into from
Closed

Conversation

ashmaroli
Copy link
Member

CAUTION!
Experimental setup.
Review at your own risk!

Summary

Sanity check with sassc gem

@ashmaroli ashmaroli added the experimental Controversial proposal. Won't be reviewed or merged. label Oct 1, 2018
@DirtyF DirtyF changed the title Sanity check with sassc gem WIP: Sanity check with sassc gem Oct 1, 2018
@pathawks
Copy link
Member

pathawks commented Oct 1, 2018

What is this all about?

@ashmaroli
Copy link
Member Author

What is this all about?

@pathawks I'm just testing script/default-site with your sassc branch at jekyll-sass-converter..
The build fails because of the following line:

External.require_with_graceful_fail("sass") unless defined?(Sass)
Sass.load_paths << sass_path

I did not go into specifics in the opening comment because this PR is not intended to be merged to master

@pathawks
Copy link
Member

pathawks commented Oct 1, 2018

this PR is not intended to be merged to master

Isn’t that what the R in Pull Request stands for, a request for changes to be merged? I’m being a little bit cheeky, but I’m just trying to understand what action you are looking for with this PR.

@ashmaroli
Copy link
Member Author

I’m being a little bit cheeky

Please do not waste your time with this "branch"..
There are plenty of other "PRs" that would benefit from your feedback..

I’m just trying to understand what action you are looking for with this PR.

My primary intention was to "test" building the "default site" with the sassc-2.0.0 on Travis CI since I do not have access to a UNIX environment. Perhaps, I should've just "experimented" on my own fork instead. (I'll make it a point to do that in the future)..

As evident from the logs, theme.rb will definitely need to be patched to use the sassc gem.., and the sass-converter should ideally handle "load paths from a theme".. but that's best discussed at the plugin's repo..

@pathawks
Copy link
Member

pathawks commented Oct 1, 2018

Ok, cool 👍🏼

I wasn’t sure if you were trying to imply that there were something I needed to do for The Great Sassc Migration. I follow now.

You could always use a virtual machine 😉

@DirtyF DirtyF closed this Aug 4, 2019
@DirtyF DirtyF removed do-not-merge experimental Controversial proposal. Won't be reviewed or merged. labels Aug 4, 2019
@jekyll jekyll locked and limited conversation to collaborators Aug 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants