Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed re-wording of Sass note. :) #7392

Merged
merged 1 commit into from Nov 23, 2018
Merged

Conversation

jpasholk
Copy link
Contributor

This is a 馃敠 documentation change.

Summary

If I am understanding this right, my re-wording helps me clearly visualize what's going on in plainer English.

Context

Semver Changes

If I am understanding this right, my re-wording helps me clearly visualize what's going on in plainer English.
Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Josh 馃憤

@jpasholk
Copy link
Contributor Author

@DirtyF Yeah man!

I had to read that whole thing like 10 times to understand wtf was going on, lol. I hope my version is a bit clearer.

Also, dude that was fast!

Hope you have a wonderful Thanksgiving. :)

@DirtyF
Copy link
Member

DirtyF commented Nov 23, 2018

@jpasholk People have troubles understanding this the first time.

Any file in _sass directory is a normal .scss or .sass file and does not need empty front matter to be processed by Jekyll. We don't want to process these files, just to import them in a main Sass file that is located in the source directory.

Any Sass file, for instance /assets/css/styles.scss in the source directory, has to have the empty front matter to be processed by Jekyll. The corresponding CSS output will be then located in _site/assets/css/style.css.

To put things differently: you store various small Sass files in the _sass directory and then you import them all in your main Sass file, that has to live in the source directory to be processed by Jekyll. And everytime you want Jekyll to render a file, be it a Sass file, a Markown file or any other type, it has to have front matter. That's how you tell jekyll to process a file. If you just want Jekyll to copy a file to the destination folder (like a regular HTML file) you don't need to add front matter.

That is the file you want to point to in the head of your template:

<link rel="stylesheet" href="{{ "/assets/css/styles.css" | relative_url }}">

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit 6244819 into jekyll:master Nov 23, 2018
jekyllbot added a commit that referenced this pull request Nov 23, 2018
@jpasholk
Copy link
Contributor Author

@DirtyF Yeah for sure. I think I'm understanding it enough to actually start using it now, rather than just vanilla CSS. This is such a nice feature of Jekyll, takes all of the work out of using Sass for the most part.

Anyway, thanks for the quick response on this man!

Cheers!!

@DirtyF
Copy link
Member

DirtyF commented Nov 23, 2018

@jpasholk 馃嵒 for your first contribution, keep'em coming 馃

@jekyll jekyll locked and limited conversation to collaborators Nov 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants