Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to easily disable disk-cache #7928

Merged
merged 4 commits into from Feb 20, 2020

Conversation

@ashmaroli
Copy link
Member

ashmaroli commented Dec 5, 2019

This is a 馃檵 feature or enhancement.

  • I've added tests
  • I've adjusted the documentation
  • The test suite passes locally

Summary

Running in safe mode just to disable Jekyll 4.0's disk-caching seems like an overkill.
Plugins would need to be modified to be compatible with safe mode, whitelist gems...

With this change one can disable disk-cache in non-safe mode via either --disable-disk-cache CLI switch or disable_disk_cache: true configuration.

Context

Closes #7804
/cc @Convincible

@DirtyF
DirtyF approved these changes Dec 5, 2019
@DirtyF

This comment has been minimized.

Copy link
Member

DirtyF commented Dec 5, 2019

@ashmaroli 馃憤 for the implementation, tests should pass though

ashmaroli added 3 commits Dec 9, 2019
Mercenary interprets `--no-*` as a falsy. But we need `disable_disk_cache`
to have a truthy value instead.
@ashmaroli ashmaroli requested review from DirtyF and jekyll/core Dec 9, 2019
@DirtyF
DirtyF approved these changes Dec 9, 2019
Copy link
Member

DirtyF left a comment

馃憣 Perfect.

@ashmaroli ashmaroli added this to the 4.1 milestone Dec 27, 2019
@ashmaroli ashmaroli requested a review from jekyll/core Feb 20, 2020
@mattr-
mattr- approved these changes Feb 20, 2020
Copy link
Member

mattr- left a comment

Dope.

@mattr-

This comment has been minimized.

Copy link
Member

mattr- commented Feb 20, 2020

@jekyllbot: merge +minor

@jekyllbot jekyllbot merged commit 558e05e into jekyll:master Feb 20, 2020
7 checks passed
7 checks passed
SUITE: test / OS: ubuntu-latest
Details
SUITE: test / OS: windows-latest
Details
SUITE: default-site / OS: ubuntu-latest
Details
SUITE: default-site / OS: windows-latest
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/jekyllrb/deploy-preview Deploy preview ready!
Details
jekyllbot added a commit that referenced this pull request Feb 20, 2020
@ashmaroli ashmaroli deleted the ashmaroli:skip-disk-cache branch Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

4 participants
You can鈥檛 perform that action at this time.