Add details in warning message to reveal --future switch #8112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add details in warning for posts that have a date in the future to reveal the --future switch
DirtyF
approved these changes
Apr 13, 2020
DirtyF
reviewed
Jan 13, 2021
| @@ -76,7 +76,7 @@ def processable?(doc) | |||
| def publishable?(doc) | |||
| site.publisher.publish?(doc).tap do |will_publish| | |||
| if !will_publish && site.publisher.hidden_in_the_future?(doc) | |||
| Jekyll.logger.warn "Skipping:", "#{doc.relative_path} has a future date" | |||
| Jekyll.logger.warn "Skipping:", "#{doc.relative_path} has a future date, run jekyll with --future to publish anyway" | |||
There was a problem hiding this comment.
Suggested change
| Jekyll.logger.warn "Skipping:", "#{doc.relative_path} has a future date, run jekyll with --future to publish anyway" | |
| Jekyll.logger.warn "Skipping:", "#{doc.relative_path} has a future date. You can pass --future option if you want to publish posts with a future date." |
There was a problem hiding this comment.
I like the idea of providing docs from the CLI, but here this might be too verbose and not a so common use case.
@jekyll/core Do we really need to enhance our warning here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a 馃檵 feature or enhancement.
Summary
The warning that says "Skipping: POST has a future date" doesn't do anything to suggest that there's a way around that.
jekyll serve --helpdoes show that the--futureswitch exists, but I thought that adding it to the message would be helpful.Context
Every 6 months I write a post for a future date, run
bundle exec jekyll sto verify it locally, see that my post isn't posted and wonder if there's a way around it. This would help my brain. ;)Not sure if you're really interested in this, but throwing it out there just in case. Thanks!