Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to build and profile third-party repo #8398

Merged
merged 1 commit into from Sep 17, 2020

Conversation

ashmaroli
Copy link
Member

Summary

A GitHub Actions Workflow to build a third-party repository and profile memory usage of the build as well.
The third-party repository is a slightly modified fork of public repo https://github.com/tomjoht/tomjoht.github.io which was earlier used in the (now retired) Utterson check-runs.

  • Using the fork means the contents don't change over time even if the original upstream repository adds new content.
  • The memory-profiling script only traces files with the stub lib/jekyll/ in order to better expose relevant information.

@DirtyF
Copy link
Member

DirtyF commented Sep 17, 2020

Is it intended to replace the profile docs on Travis?

@ashmaroli
Copy link
Member Author

Is it intended to replace the profile docs on Travis?

Not really.
The profile-docs and memprof jobs on Travis and AppVeyor uses jekyllrb's source as subject. This workflow uses a third-party repository which contains a huge lot more pages and documents than jekyllrb's source directory, which will give us additional insight on the various optimizations / changes.

Copy link
Member

@DirtyF DirtyF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 A bot that sends a benchmark summary on every PR that modifies the jekyll lib 🔥

@ashmaroli
Copy link
Member Author

A bot that sends a benchmark summary on every PR that modifies the jekyll lib

That's a great idea @DirtyF!!
I'll look into having a workflow for that..

Merging this for the time being to be used in open PRs about optimizations..
@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit c066999 into jekyll:master Sep 17, 2020
jekyllbot added a commit that referenced this pull request Sep 17, 2020
@ashmaroli ashmaroli removed the fix label Sep 17, 2020
@ashmaroli ashmaroli deleted the third-party-repository-workflow branch September 17, 2020 13:54
@jekyll jekyll locked and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants