Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: enable new cops #8538

Merged
merged 5 commits into from
Jan 12, 2021
Merged

style: enable new cops #8538

merged 5 commits into from
Jan 12, 2021

Conversation

DirtyF
Copy link
Member

@DirtyF DirtyF commented Jan 7, 2021

This is a ๐Ÿ‘จ๐Ÿปโ€๐ŸŽค style enhancement.

Summary

  • Bump to Rubocop 1.8.0 ๐Ÿ†™
  • Enable new cops ๐Ÿ‘ฎ๐Ÿป
  • Add extensions for minitest, rake and rspec ๐Ÿ’…๐Ÿป
  • Lint Robucop config file โœ…
  • Auto-correct โœจ

Copy link
Member

@ashmaroli ashmaroli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor thoughts.. ๐Ÿ‘ otherwise..

test/test_filters.rb Show resolved Hide resolved
.rubocop.yml Outdated Show resolved Hide resolved
.rubocop.yml Outdated Show resolved Hide resolved
@DirtyF DirtyF requested a review from ashmaroli January 12, 2021 19:21
@DirtyF
Copy link
Member Author

DirtyF commented Jan 12, 2021

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit 8c8326e into master Jan 12, 2021
@DirtyF DirtyF removed the request for review from ashmaroli January 12, 2021 23:39
@jekyllbot jekyllbot deleted the test/rubocop-1.8.0 branch January 12, 2021 23:39
jekyllbot added a commit that referenced this pull request Jan 12, 2021
github-actions bot pushed a commit that referenced this pull request Jan 12, 2021
Frank Taillandier: style: enable new cops (#8538)

Merge pull request 8538
@jekyll jekyll locked and limited conversation to collaborators Jan 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants