Update include tag to be more permissive #8618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These special characters include '@' '#' '~' '+' '(' ')' '-' '{' '}' '[' and ']'.
https://en.wikipedia.org/wiki/Filename
parkr
requested review from
a team,
mattr- and
ashmaroli
and removed request for
a team
mattr-
approved these changes
Mar 26, 2021
|
@mattr- Thank you! I removed |
@ashmaroli Hi! Are these style checks failing on |
|
@parkr I fixed the styles for Rubocop 1.12 |
|
@jekyll: merge +minor |
jekyllbot
added a commit
that referenced
this pull request
Mar 27, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Mar 27, 2021
Parker Moore: Update include tag to be more permissive (#8618) Merge pull request 8618
|
@DirtyF i can't remember - is there an easy way to backport this to 3.x? I can't remember if @jekyllbot can do it for us or not. |
|
@parkr I never done a backport but according to parkr/auto-reply#31 @jekyllbot can't do this. There's a script/backport-pr in Jekyll's repository though |
parkr
added a commit
that referenced
this pull request
Apr 6, 2021
parkr
added a commit
that referenced
this pull request
Apr 7, 2021
Backport #8618 for v3.9.x: Update include tag to be more permissive
This was referenced Aug 25, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our
{% include %}tag presently isn't permissive enough to handle many valid filenames, includefoo@bar.html. This@symbol is used by systems within the Node ecosystem and theincludetag is often used to selectively include HTML/JS/CSS from within a Node package in a Jekyll site.This does not include any of the reserved characters: https://en.wikipedia.org/wiki/Filename#Reserved_characters_and_words
It adds support for the following characters:
@#~+-(and)Context
This PR continues the work that @Convincible did in #7096.
We'd like to be able to use this in GitHub Pages, so I'll plan a back port to Jekyll 3.x as well.