Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expect to cover docs/_posts #8677

Merged
merged 1 commit into from May 16, 2021
Merged

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented May 16, 2021

This is a 馃悰 bug fix.

Summary

check-spelling is currently checking docs/ (including _posts/) but when its original corrections were landed, they ignored _posts/, so certain additional items needed to be added to expect.txt

Context

This applies #8676 (comment) (which was introduced with the landing of #8675)

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>
@kmk3
Copy link
Contributor

kmk3 commented May 16, 2021

So I started writing #8678 before this was posted and ended afterwards; I'll
just copy part of what I said there:

Suggestion: Ignore the docs/_posts directory to avoid having to start
adding/maintaining contributor names on the dictionary.

On a related note, while I see the value in spell checking code and
documentation (which are usually the most frequently changed parts), I noticed
that in #8661 there were spelling changes done to the files in docs/_posts.
Personally, I would have refrained from doing so, as many of them are
old/historical publications (e.g.: one of the files changed is from 2013),
whose textual content I would consider rather "set in stone" at this point in
time.

@DirtyF
Copy link
Member

DirtyF commented May 16, 2021

@jekyll: merge +dev

@jekyllbot jekyllbot merged commit 92633c6 into jekyll:master May 16, 2021
jekyllbot added a commit that referenced this pull request May 16, 2021
github-actions bot pushed a commit that referenced this pull request May 16, 2021
Josh Soref: Update expect to cover docs/_posts (#8677)

Merge pull request 8677
@jsoref jsoref deleted the spell-check branch June 30, 2021 20:16
@jekyll jekyll locked and limited conversation to collaborators Jun 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants