Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Goodbye Frank. We'll miss you. 馃挃 #8807

Merged
merged 4 commits into from Sep 14, 2021
Merged

Goodbye Frank. We'll miss you. 馃挃 #8807

merged 4 commits into from Sep 14, 2021

Conversation

mattr-
Copy link
Member

@mattr- mattr- commented Sep 14, 2021

Perhaps this post could be longer, but I don't really know what else to say.

@mattr- mattr- requested review from a team, parkr and ashmaroli and removed request for a team September 14, 2021 17:16
parkr
parkr approved these changes Sep 14, 2021
View reviewed changes
Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃挃 馃槩

@ashmaroli ashmaroli requested review from parkr and removed request for ashmaroli September 14, 2021 19:13
@ashmaroli
Copy link
Member

@mattr- I rewrote the goodbye note.

mattr-
mattr- commented Sep 14, 2021
View reviewed changes
Copy link
Member Author

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is beautiful. I fixed a few typos, but that's it.

Thanks for taking my poor writing and greatly enhancing it. 鉂わ笍

docs/_posts/2021-09-14-goodbye-dear-frank.markdown Outdated Show resolved Hide resolved
docs/_posts/2021-09-14-goodbye-dear-frank.markdown Outdated Show resolved Hide resolved
@ashmaroli @mattr-
Fix typo
3abac58 
Co-authored-by: Matt Rogers <codemattr@gmail.com>
@ashmaroli
Copy link
Member

@parkr Requesting a re-review. Feel free to squash-merge and publish when ready.
Thank you.

@mattr-
Copy link
Member Author

mattr- commented Sep 14, 2021

I'm going to go ahead and merge this.

馃挃 馃槩

@jekyllbot: merge +docs

@jekyllbot jekyllbot merged commit f831286 into master Sep 14, 2021
@jekyllbot jekyllbot deleted the in-memory-of-frank branch September 14, 2021 19:32
jekyllbot added a commit that referenced this pull request Sep 14, 2021
@jekyllbot
Update history to reflect merge of #8807 [ci skip]
c238346
github-actions bot pushed a commit that referenced this pull request Sep 14, 2021
@jekyllbot
Deploy docs from f831286
059f364 
Matt Rogers: Goodbye Frank. We'll miss you. 馃挃 (#8807)

Merge pull request 8807
ashmaroli and others added 2 commits September 15, 2021 12:41
@ashmaroli
Rewrite goodbye note
170b87b
@ashmaroli @mattr-
Update grammar
8a62c43 
Co-authored-by: Matt Rogers <codemattr@gmail.com>
@mariealine
Copy link

Hello folks,

I didn't know how to contact you in a more traditional way.
I just read this blog post.
Frank was a close friend.
Reading your words means a lot to me. Thank you a lot for sharing.
Take care

Marie-Aline Millot

@ashmaroli
Copy link
Member

Hello @mariealine
Thank you for reaching out to us and sharing your sentiments.
Hopefully, Frank is in a better place now and every time someone here thinks positively of him, things get better for him.

:)
Ashwin M

@jekyll jekyll locked and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@parkr parkr Awaiting requested review from parkr

Assignees
No one assigned
Labels
documentation frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mattr- @ashmaroli @mariealine @parkr @jekyllbot