Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a workflow to build gems consistently #8830

Merged
merged 2 commits into from
Nov 5, 2021

Conversation

ashmaroli
Copy link
Member

Summary

Use GH Actions to build gem.
(Push to Rubygems.org manually)

With this Ruby version and platform remains consistent when triggered by different maintainers.

Context

As part of responding to #8826 (which will be closed after v4.2.2 is shipped and a release post is published).
This will be back ported to 4.2-stable and 3.9-stable.

@ashmaroli ashmaroli added backport-candidate Consider for merge into an older stable branch internal labels Sep 30, 2021
@ashmaroli
Copy link
Member Author

Since this workflow will not be triggered for the current context, you may view the run on my fork at https://github.com/ashmaroli/jekyll/actions/runs/1291299525 for analysis.

Copy link
Member

@mattr- mattr- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about evolving this action so that it can be used to release the gem? We could use the push of the tag to trigger this workflow instead of the commit message, and then set up the actions secrets to push the gem.

We might want to create a jekyllbot user on rubygems so that the authentication is not tied to our accounts as well.

I really like the idea of getting the process of making a release off our local machines. Thanks for getting this started.

@ashmaroli
Copy link
Member Author

What do you think about evolving this action so that it can be used to release the gem?

Our release process for backports is not straight-forward and involves switching branches multiple commits. Automating that is definitely beneficial but I didn't do that in the initial phase to have greater control n err on the safer side.

We might want to create a jekyllbot user on rubygems so that the authentication is not tied to our accounts as well.

👍

@parkr
Copy link
Member

parkr commented Oct 2, 2021

I setup a jekyllbot RubyGems account. I'm all for automating this, especially if it were as simple as adding a Git tag. I have added a secret called RUBYGEMS_GEM_PUSH_API_KEY to the org for use in our gem repos. Right now jekyllbot doesn't have access to anything, but it'd be cool to validate with a gem that's less important (maybe like a Jekyll-import or something?). What do you think?

@ashmaroli
Copy link
Member Author

it'd be cool to validate with a gem that's less important (maybe like a Jekyll-import or something?)...

We could use https://github.com/jekyll/jekyll-test-gem-plugin for this purpose.
Since it is not consumer-oriented and is intuitively named, we could play around with it without being concerned of side-effects.

Copy link
Member

@parkr parkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can run this once we give jekyllbot the appropriate permissions for the gem.

@ashmaroli
Copy link
Member Author

@jekyllbot: merge +dev

@jekyllbot jekyllbot merged commit db3f034 into jekyll:master Nov 5, 2021
@jekyllbot jekyllbot added the fix label Nov 5, 2021
@ashmaroli ashmaroli deleted the gem-build-workflow branch November 5, 2021 10:29
jekyllbot added a commit that referenced this pull request Nov 5, 2021
github-actions bot pushed a commit that referenced this pull request Nov 5, 2021
Ashwin Maroli: Add a workflow to build gems consistently (#8830)

Merge pull request 8830
ashmaroli added a commit to ashmaroli/jekyll that referenced this pull request Nov 5, 2021
Add a workflow to build gems consistently
This backports db3f034 to 4.2-stable
ashmaroli added a commit that referenced this pull request Dec 9, 2021
…8869)

Add a workflow to build gems consistently
This backports db3f034 to 4.2-stable
@jekyll jekyll locked and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport-candidate Consider for merge into an older stable branch fix frozen-due-to-age internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants