Relax Rubocop Dependency #8831
Merged
Relax Rubocop Dependency #8831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The formatting in the test files is better than what Rubocop is suggesting, so tell rubocop to ignore the rule in these test files.
|
Thank you @mattr- |
jekyllbot
added a commit
that referenced
this pull request
Sep 30, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
Matt Rogers: Relax Rubocop Dependency (#8831) Merge pull request 8831
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bumps Rubocop to 1.22.0 to fix #8827 and tells Rubocop to ignore a couple bits of code in the tests where our formatting is clearer than Rubocop's suggested replacement
Context
Closes #8765
Closes #8773
Closes #8790
Closes #8805
Closes #8827