Expose collection static files via site.static_files

[ashmaroli]

• This is a 🙋 feature or enhancement.
• I've added tests.

Summary

Jekyll::Site#static_files should expose all static files in the site. Even those static files read from within collections.

Context

Resolves #8901

[parkr]

Looks like cucumber is upset. Otherwise, LGTM!

[ashmaroli]

Looks like cucumber is upset.

Site#documents contains both Collection#docs and Collection#files.
While Site#docs_to_write essentially yields a filtered array of writable collection items, Site#each_site_file includes Site#static_files in addition to Site#docs_to_write.

jekyll/lib/jekyll/site.rb

Lines 228 to 232 in 8690765

	def write
	Jekyll::Commands::Doctor.conflicting_urls(self)
	each_site_file do |item|
	item.write(dest) if regenerator.regenerate?(item)
	end

jekyll/lib/jekyll/site.rb

Lines 355 to 356 in 8690765

	def each_site_file
	%w(pages static_files docs_to_write).each do |type|

jekyll/lib/jekyll/site.rb

Lines 342 to 344 in 8690765

	def docs_to_write
	documents.select(&:write?)
	end

jekyll/lib/jekyll/site.rb

Lines 349 to 353 in 8690765

	def documents
	collections.each_with_object(Set.new) do |(_, collection), set|
	set.merge(collection.docs).merge(collection.files)
	end.to_a
	end

Therefore, to maintain backwards-compatibility of Site#each_site_file, introduce Site#static_files_to_write

[parkr]

Nice, clean implementation. Well done, @ashmaroli!

[ashmaroli]

ping @mattr- for a re-review.

[ashmaroli]

ping @mattr- for a re-review.

[ashmaroli]

@jekyllbot: merge +minor