Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure theme config is a Jekyll::Configuration object #8988

Conversation

ashmaroli
Copy link
Member

  • This is a 馃悰 bug fix.
  • I've added tests.

Summary

site.config merged with theme_config should continue responding to methods defined in Jekyll::Configuration class.

Context

Consider backporting to 4.2 series

@ashmaroli ashmaroli added backport-candidate Consider for merge into an older stable branch bug labels Mar 7, 2022
@ashmaroli ashmaroli requested review from mattr- and parkr March 21, 2022 14:52
@ashmaroli
Copy link
Member Author

ping @mattr-

@ashmaroli
Copy link
Member Author

@jekyllbot: merge +fix

@jekyllbot jekyllbot merged commit 3b3f845 into jekyll:master Apr 8, 2022
@jekyllbot jekyllbot added the fix label Apr 8, 2022
jekyllbot added a commit that referenced this pull request Apr 8, 2022
github-actions bot pushed a commit that referenced this pull request Apr 8, 2022
Ashwin Maroli: Ensure theme config is a `Jekyll::Configuration` object (#8988)

Merge pull request 8988
@jekyll jekyll locked and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport-candidate Consider for merge into an older stable branch bug fix frozen-due-to-age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants