Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract incremental build logic into separate classes #9148

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

ashmaroli
Copy link
Member

  • This is a 馃敤 code refactoring.

Summary

The major methods of Jekyll::Regenerator check if site.config["incremental"] to determine course of action. This is a code-smell.
Therefore, stop such checks on every call and extract the incremental logic into a new subclass.
Additionally, subclass Jekyll::Site to use the new Regenerator subclass.

@ashmaroli ashmaroli marked this pull request as ready for review October 5, 2022 18:13
@ashmaroli ashmaroli requested review from mattr- and parkr October 5, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant