Respect user-defined name attribute in documents #9167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jekyllbot: merge +fix |
jekyllbot
added a commit
that referenced
this pull request
Oct 26, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
Ashwin Maroli: Respect user-defined name attribute in documents (#9167) Merge pull request 9167
ashmaroli
pushed a commit
that referenced
this pull request
Oct 27, 2022
lylo
pushed a commit
to lylo/jekyll
that referenced
this pull request
Oct 27, 2022
Merge pull request 9167
lylo
pushed a commit
to lylo/jekyll
that referenced
this pull request
Oct 27, 2022
lylo
pushed a commit
to lylo/jekyll
that referenced
this pull request
Oct 27, 2022
* master: (27 commits) Remove noise in `features/highlighting.feature` Release 馃拵 v4.3.1 Update history to reflect merge of jekyll#9171 [ci skip] Release post for v4.3.1 (jekyll#9171) Update history to reflect merge of jekyll#9170 [ci skip] Revert "Incrementally rebuild when a data file is changed (jekyll#8771)" (jekyll#9170) Update history to reflect merge of jekyll#9167 [ci skip] Respect user-defined name attribute in documents (jekyll#9167) Revert back to developing 4.3.x Mark initiation of v5.0 development Disable critical GH Actions on `master` Fix spelling errors in History document Release 馃拵 v4.3.0 Update history to reflect merge of jekyll#9157 [ci skip] Release post for v4.3.0 (jekyll#9157) Clean up HEAD section in History document Document xz dependency on macOS (jekyll#9098) Fix URL to Liquid documentation (jekyll#9158) Bump RuboCop to `v1.37.x` Update history to reflect merge of jekyll#9132 [ci skip] ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix break in expected behavior where value of
Document#data["name"]would translate over to Liquid templates as{{ page.name }}. This was broken in v4.3.0 when{{ page.name }}was made to delegate toDocument#basenamefor parity withPageobjects.Context
Resolves #9164
?? #9165