Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Rubocop to version 1.48.x #9326

Merged
merged 2 commits into from
Mar 26, 2023
Merged

Bump Rubocop to version 1.48.x #9326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b1401a
Change rubocop gem version to 1.48.x in gemfile
waqarnazir Mar 25, 2023
c5e450c
Enable Min Max comparison cop and linted the respective code
waqarnazir Mar 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -368,7 +368,7 @@ Style/GuardClause:
Style/HashAsLastArrayItem:
Enabled: true
Style/HashConversion:
Enabled: true
Enabled: true
Style/HashEachMethods:
Enabled: true
Style/HashExcept:
Expand All @@ -392,6 +392,8 @@ Style/MapCompactWithConditionalBlock:
Enabled: true
Style/MapToHash:
Enabled: true
Style/MinMaxComparison:
Enabled: true
Style/MixinUsage:
Exclude:
- test/helper.rb
Expand Down
2 changes: 1 addition & 1 deletion Gemfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ group :test do
gem "nokogiri", "~> 1.7"
gem "rspec"
gem "rspec-mocks"
gem "rubocop", "~> 1.45.0"
gem "rubocop", "~> 1.48.0"
gem "rubocop-minitest"
gem "rubocop-performance"
gem "rubocop-rake"
Expand Down
2 changes: 1 addition & 1 deletion lib/jekyll/site.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,7 @@ def load_theme_configuration(config)
# Returns nothing
def limit_posts!
if limit_posts.positive?
limit = posts.docs.length < limit_posts ? posts.docs.length : limit_posts
limit = [posts.docs.length, limit_posts].min
posts.docs = posts.docs[-limit, limit]
end
end
Expand Down