Cherry pick logger fix for Ruby 3.3 #9510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request 9392
Merge pull request 9469
Merge pull request 9196
mattr-
approved these changes
Dec 27, 2023
|
Looks fine to me. Will get this merged and start running through the release process in a couple of hours. |
HyukjinKwon
pushed a commit
to apache/spark
that referenced
this pull request
Jan 9, 2024
….3.0
### What changes were proposed in this pull request?
1. Bump jekyll to 4.3.3.
2. Loosen the dependency spec for jekyll to make updates easier.
3. Don't mention Ruby 1 or 2 in the docs.
4. Don't use `sudo` with `gem` in the docs.
### Why are the changes needed?
1. Jekyll 4.3.2 is [broken on Ruby 3.3.0][1]. Jekyll 4.3.3 [fixes the issue][2].
2. There is no need to pin Jekyll in the Gemfile since it gets pinned automatically for us in the lock file. This makes updating dependencies via `bundle update` easier.
3. Both Ruby 1 and 2 are [EOL][eol]. We should not use or reference them in the docs.
4. Installing stuff as the superuser is explicitly discouraged by both pip and gem. Pip issues this warning:
> WARNING: Running pip as the 'root' user can result in broken permissions and conflicting behaviour with the system package manager. It is recommended to use a virtual environment instead: https://pip.pypa.io/warnings/venv
And bundler issues this warning:
> Don't run Bundler as root. Installing your bundle as root will break this application for all non-root users on this machine.
We should not encourage this pattern in our docs.
[1]: jekyll/jekyll#9510
[2]: https://github.com/jekyll/jekyll/releases/tag/v4.3.3
[eol]: https://www.ruby-lang.org/en/news/2022/04/12/ruby-2-7-6-released/
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Building the docs against Ruby 3.2.2 and 3.3.0.
### Was this patch authored or co-authored using generative AI tooling?
No.
Closes #44628 from nchammas/SPARK-46626-jekyll-ruby.
Authored-by: Nicholas Chammas <nicholas.chammas@gmail.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports #9392 to 4.3 stable branch. This change is backward compatible with older version of logger. We should fix this as soon as possible, because Jekyll is completely unusable on Ruby 3.3 right now. In my test this is the only patch required for Ruby 3.3.
This also picks #9469 and #9196, but these are test-only fixes for the CI.
cc @parkr @ashmaroli Can you please help take a look and perhaps cut a patch release? Thank you.