Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emoji shouldn't be compiled in code block #12

Closed
owenthereal opened this issue Jul 31, 2014 · 10 comments · Fixed by #33
Closed

emoji shouldn't be compiled in code block #12

owenthereal opened this issue Jul 31, 2014 · 10 comments · Fixed by #33

Comments

@owenthereal
Copy link

I'm trying to show the emoji raw code in GitHub pages like this: :metal:, but jekyll renders it as raw image tag. For example, the result of

:metal:
`:metal:`

is

screen shot 2014-07-30 at 7 06 20 pm

Other places like GitHub issues or wikis works as expected but not GitHub pages.

@parkr
Copy link
Member

parkr commented Jul 31, 2014

We just use the EmojiFilter. How do you expect it to be rendered? Maybe GFM works well with this, but not whatever renderer you're using?

/cc @benbalter

@owenthereal
Copy link
Author

I would expect something like this:

🤘

:metal:

@benbalter
Copy link
Contributor

See also jekyll/jekyll-mentions#7. Support is baked into html-pipeline, but jemoji is run on the markdown, no the rendered HTML, due to limitations within Jekyll itself.

@owenthereal
Copy link
Author

@benbalter is there any temporary solution for now? What's the timeline for jekyll 2.0?

@parkr
Copy link
Member

parkr commented Jul 31, 2014

@benbalter Why not add this as a converter instead of a generator? Just return true in the matches method so everything gets passed through.

@benbalter
Copy link
Contributor

Why not add this as a converter instead of a generator?

Can a file have multiple converters?

@parkr
Copy link
Member

parkr commented Jul 31, 2014

@benbalter It ought to! A simple change if not yet.

@owenthereal
Copy link
Author

Any updates on this?

@parkr
Copy link
Member

parkr commented Dec 1, 2014

Need to fix this in html-pipeline.

@parkr parkr closed this as completed Dec 1, 2014
@kvz
Copy link

kvz commented Oct 1, 2015

Running into this now as well:

Not sure if you suggest I can fix via upgrading?

@parkr parkr reopened this Oct 1, 2015
@jekyll jekyll locked and limited conversation to collaborators Apr 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants