Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shouldn't mention in code block. #7

Closed
chunlea opened this issue Apr 14, 2014 · 8 comments
Closed

Shouldn't mention in code block. #7

chunlea opened this issue Apr 14, 2014 · 8 comments

Comments

@chunlea
Copy link

chunlea commented Apr 14, 2014

I found that jekyll-mentions turns such @import in code block to github users' link. It is annoying, right?

I think we need to add some roles to ignore some phrases like @import. I like mentions, but I don't want to destory my code block.

@benbalter
Copy link
Contributor

This can be fixed once Jekyll 2.0.0 :ships: as we should be able to modify the HTML (rather than the markdown input) and could properly know if something is inside a code block via the tree.

Until then, using @ instead of @ should escape the linkification, I believe.

/cc @parkr in case the use case is helpful for callback planning.

@caarlos0
Copy link

using @ didn't work :/

@le717
Copy link

le717 commented Nov 25, 2014

I can extend this report further now that Jekyll 2 is on GHP. Mentions should also not occur in <style> and <script> tags. I've had this happen on my site in a script tag (and currently does), and I had to move some CSS into a external file because this gem was breaking the @media rule.

@parkr
Copy link
Member

parkr commented Nov 25, 2014

This should be fixed in HTML Pipeline: jch/html-pipeline

@parkr
Copy link
Member

parkr commented Dec 1, 2014

Tracking upstream.

aleung added a commit to f5f6/f5f6.github.io that referenced this issue Jan 9, 2015
@davidcelis
Copy link

Is this fixed in the version running on the github-pages gem? The issue is still present in the latest release of that...

@le717
Copy link

le717 commented Apr 24, 2015

@davidcelis No clue. gjtorikian/html-pipeline#163 was closed and I can't find any further discussion about fixing it. I just hit the same issue I reported in #7 (comment), but this time with an @keyframes rule.

le717 pushed a commit to le717/le717.github.io that referenced this issue Apr 24, 2015
@parkr parkr reopened this Apr 24, 2015
@sandipb
Copy link

sandipb commented May 14, 2015

This breaks code highlighting for me right now. Had to disable the plugin to make highlighting work.

This was breaking for me.

{% highlight bash %}
$ echo hello > /dev/null
{% endhighlight %}

The problem is that the plugin is HTML escaping everything, including > breaking pygments because now its regexes won't match.

hughker added a commit to internalfx/quickshot-docs that referenced this issue May 15, 2015
- At least until jekyll/jekyll-mentions#7 is
fixed
- Was processing SCSS `@import` references
silvenon added a commit to janko/janko.io that referenced this issue May 17, 2015
fdavidcl added a commit to libreim/blog that referenced this issue Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants