Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open social links in new tabs #625

Merged
merged 2 commits into from
Dec 30, 2021
Merged

Open social links in new tabs #625

merged 2 commits into from
Dec 30, 2021

Conversation

mattr-
Copy link
Member

@mattr- mattr- commented Dec 29, 2021

Reapplication of #556 since the underlying repository is gone and that PR was already approved.

added `target="_blank"` to all links.
You don't want to lose visitors from your website, so you open in a new tab.

Signed-off-by: Matt Rogers <codemattr@gmail.com>
@ashmaroli
Copy link
Member

Going to merge this without Jekyllbot as the bot doesn't support credits to co-authors..
Hence the manual entry to our History document in commit 49b0981.

@ashmaroli
Copy link
Member

Thank you @yshmarov and @mattr-

@ashmaroli ashmaroli merged commit 6513ea8 into master Dec 30, 2021
@ashmaroli ashmaroli deleted the new-tab-for-social-links branch December 30, 2021 11:47
@jekyll jekyll locked and limited conversation to collaborators Dec 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants