Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal fixes for Disqus #775

Merged
merged 1 commit into from
May 8, 2024
Merged

Minimal fixes for Disqus #775

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion _includes/disqus_comments.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<div id="disqus_thread"></div>
<script>
var disqus_config = function () {
this.page.url = '{{ page.url | absolute_url }}';
this.page.url = '{{ absolute_url }}';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

absolute_url is a filter (https://jekyllrb.com/docs/liquid/filters/), and, from my knowledge and testing, it doesn't do anything when used directly.

So, shouldn't this be changed to

this.page.url = '';

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this did not work for me on GitHub pages.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does {{ absolute_url }} expand to, in your case?

I tested, and in my case, it expands to nothing: this.page.url = '';, which is what I assumed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. in my case it's this.page.url = '';

this.page.identifier = '{{ page.url | absolute_url }}';
};

Expand Down