Minimal fixes for Disqus #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattr-
approved these changes
May 8, 2024
revolter
reviewed
May 11, 2024
| @@ -3,7 +3,7 @@ | |||
| <div id="disqus_thread"></div> | |||
| <script> | |||
| var disqus_config = function () { | |||
| this.page.url = '{{ page.url | absolute_url }}'; | |||
| this.page.url = '{{ absolute_url }}'; | |||
There was a problem hiding this comment.
absolute_url is a filter (https://jekyllrb.com/docs/liquid/filters/), and, from my knowledge and testing, it doesn't do anything when used directly.
So, shouldn't this be changed to
this.page.url = '';?
There was a problem hiding this comment.
I think this did not work for me on GitHub pages.
There was a problem hiding this comment.
What does {{ absolute_url }} expand to, in your case?
I tested, and in my case, it expands to nothing: this.page.url = '';, which is what I assumed.
There was a problem hiding this comment.
You are right. in my case it's this.page.url = '';
|
Woke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I create local modification, and only using absolute URL make Disqus works.