avoid unnecessary recalculations of required height #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculating the required height is an expensive operation.
`Element.getComputedStyles()`, `Element.scrollHeight` and other features
used require the browser to recalculate styles and layout. We should make
sure that this is only done once per render.
Such an resize could be triggered by both the input event and a changed
argument in the same render. Actually that's very likely as could be seen
by this template:
<textarea
value={{this.val}}
{{autoresize this.val}}
{{on "input" (action (mut this.val) value="target.value")}}
/>
This requires to track if resize has been scheduled even if arguments are
changed. This is something which is not good supported by functional
modifiers. Therefore the implementation is refactored to use class modifiers
instead as part of this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculating the required height is an expensive operation.
Element.getComputedStyles(),Element.scrollHeightand other features used require the browser to recalculate styles and layout. We should make sure that this is only done once per render.Such an resize could be triggered by both the input event and a changed argument in the same render. Actually that's very likely as could be seen by this template:
This requires to track if resize has been scheduled even if arguments are changed. This is something which is not good supported by functional modifiers. Therefore the implementation is refactored to use class modifiers instead as part of this change.
Closes #8