Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for file types from CLI args #6

Closed
wants to merge 1 commit into from

Conversation

sweep-ai[bot]
Copy link
Contributor

@sweep-ai sweep-ai bot commented Oct 15, 2023

PR Feedback (click)

  • 馃憤 Sweep Did Well
  • 馃憥 Sweep Needs Improvement

Description

This PR adds support for specifying file types from the command line when running the cspell-tool. Currently, the tool is hardcoded to check spelling in markdown, TypeScript, and JSON files. With this change, users will be able to specify the file types they want to check, making the tool more flexible and customizable.

Summary of Changes

  • Added import for the process module from Node.js to access command line arguments.
  • Created a new function getFileTypesFromArgs to extract file types from command line arguments.
  • Updated the cspell command construction to use the file types obtained from getFileTypesFromArgs.
  • Updated relevant docstrings to reflect the changes.

Please review and merge this PR at your earliest convenience.

Fixes #5.


馃帀 Latest improvements to Sweep:

  • Sweep can now passively improve your repository! Check out Rules to learn more.

馃挕 To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

@sweep-ai
Copy link
Contributor Author

sweep-ai bot commented Oct 15, 2023

Rollback Files For Sweep

  • Rollback changes to cli/index.js

@sweep-ai
Copy link
Contributor Author

sweep-ai bot commented Oct 15, 2023

Apply Sweep Rules to your PR?

  • Apply: Leftover TODOs in the code should be handled.
  • Apply: All new business logic should have corresponding unit tests in the tests/ directory.
  • Apply: Any clearly inefficient or repeated code should be optimized or refactored.

@sweep-ai sweep-ai bot added the sweep label Oct 15, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 15, 2023

鈿狅笍 No Changeset found

Latest commit: 7afa5f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sweep-ai sweep-ai bot mentioned this pull request Oct 15, 2023
2 tasks
@sweep-ai sweep-ai bot closed this Oct 15, 2023
@sweep-ai sweep-ai bot deleted the sweep/cli-file-types branch October 15, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: Support file types from CLI args
0 participants