Media folder api #39
Merged
Media folder api #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In this case, I like to put: at the bottom of the commit message so they get credit if I was only inspired by their idea. |
Erotemic
force-pushed
the
media-folder-api
branch
from
3acecae
to
23d75ab
Compare
|
@s-t-e-v-e-n-k TIL, thanks. For my (and others) reference, adding such a line to a commit message is supported by github. It doesn't seem to reflect anything special in the git log itself (except for the text), but that's ok. It's at least clear that @qishen was involved. This should now be ready for review / merge. |
iwalton3
requested changes
Jan 21, 2024
Co-authored-by: qishen <qishen@users.noreply.github.com>
Erotemic
force-pushed
the
media-folder-api
branch
from
6219186
to
1bd3ab6
Compare
iwalton3
approved these changes
Jan 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small part of #11 I'm interested in using. I made a small change on top to accept a suggestion made in that discussion and I renamed "scan library" to "refresh library" to be consistent with the API names.
I attempted to keep the original author as part of the commit, but it looks like that didn't work. Not sure if there is a good way to give credit there.