Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deprecated isPassword and line1 function parameters #308

Merged
merged 1 commit into from May 30, 2020
Merged

Update deprecated isPassword and line1 function parameters #308

merged 1 commit into from May 30, 2020

Conversation

oddstr13
Copy link
Member

The isPassword change likely bumps minimum version up to Kodi 18.
This can be worked around if desirable.

@oddstr13
Update deprecated isPassword functionality
a6241d2 
and dialog line1 to message parameter rename.

The isPassword change likely bumps minimum version up to Kodi 18.
This can be worked around if desirable.
@sonarcloud
Copy link

sonarcloud bot commented May 28, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@mcarlton00
Copy link
Member

I know we have at least one user on Matrix who was having some instability on Kodi 18 and has rolled back to Kodi 17. They said that when using multiple profiles that plays were registering on the wrong profile somehow. We should probably do some testing around this before outright ending Kodi 17 support (even if we haven't purposefully been supporting it up to this point.

The isPassword check could likely be handled via a simple version check, but we should at least investigate the profiles issue and preferably not support old versions

@mcarlton00 mcarlton00 added this to Reviewer approved in Kodi 19 via automation May 29, 2020
@mcarlton00
Copy link
Member

Issues reported on matrix seem to be related to instability in LibreElec on the user's hardware, nothing to do with us.

@mcarlton00 mcarlton00 merged commit 4e34537 into jellyfin:master May 30, 2020
Kodi 19 automation moved this from Reviewer approved to Done May 30, 2020
oddstr13 added a commit to oddstr13/jellyfin-kodi that referenced this pull request May 30, 2020
@oddstr13
Add Kodi 17 backwards compat to jellyfin#308
db51abd
mcarlton00 added a commit that referenced this pull request May 30, 2020
@mcarlton00
Merge pull request #311 from oddstr13/pr-kodi19-3
d50283b 
Add Kodi 17 backwards compat to #308
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcarlton00 mcarlton00 mcarlton00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Kodi 19
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oddstr13 @mcarlton00