Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incremental sync for mixed content libraries #315

Conversation

mcarlton00
Copy link
Member

The list of library IDs in the stored sync file looks like this:

"Whitelist": [
    "e2c00f297a5f80af390f52f72e782147",
    "767bffe4f11c93ef34b805451a696a4e",
    "Mixed:122ca211c46006b344d85950f9ed4368",
    "f137a2dd21bbc1b99aa5c0f6bf02a805",
    "7e64e319657a9516ec78490da03edccb"
]

This obviously throws errors when a mixed content library is present and prevents the incremental sync from running on startup.

We could technically find where it's being written and make them all normal item IDs instead of having this one be weird, but given how mixed content libraries are the red headed step child and have some weird behavior everywhere else anyway, I think I like the idea of making sure it stands out.

@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell B 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@TrueTechy TrueTechy merged commit e795e19 into jellyfin:master Jun 7, 2020
@mcarlton00 mcarlton00 deleted the mixed-libraries-are-bad-and-should-feel-bad branch July 18, 2020 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants