Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix music syncing for Kodi 18 retaining Kodi 17 compatibility #32

Merged
merged 2 commits into from
Jun 2, 2019
Merged

Fix music syncing for Kodi 18 retaining Kodi 17 compatibility #32

merged 2 commits into from
Jun 2, 2019

Conversation

jmeacoe
Copy link
Contributor

@jmeacoe jmeacoe commented May 28, 2019

Fixes music syncing for kodi 18 while still usable by kodi 17.
Also removes the message in kodi 18 to scan media.
tested in kodi 17 and 18.

Fixes #12
Fixes #31

Also removes the message in kodi 18 to scan media.
tested in kodi 17 and 18.
@jmeacoe
Copy link
Contributor Author

jmeacoe commented May 28, 2019

This pull request also fixes #31 which is the strArtists issue in the music72 db.

@joshuaboniface joshuaboniface changed the title fixes music syncing for kodi 18 while still usable by kodi 17. Fix music syncing for Kodi 18 retaining Kodi 17 compatibility May 29, 2019
@joshuaboniface joshuaboniface requested a review from cvium May 29, 2019 00:08
Copy link
Member

@oddstr13 oddstr13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runs just fine in Kodi 17 (I rebased on master).

If it also runs fine in Kodi 18, I'd say go for merge as soon as the indentation error is fixed.
Runs fine as is, but I would prefer not introducing formatting errors whenever possible.

I'm also assuming that 72 is the appropriate version for this distinction, as I'm not familiar with the versioning scheme, nor the exact version the music db change was introduced.

@jmeacoe
Copy link
Contributor Author

jmeacoe commented May 29, 2019

Kodi MusicDB goes from Kodi 17 - Music60 to Kodi 18 -Music72:
https://kodi.wiki/view/Databases#Database_Versions
I will fix the indentation when I get home from work.

@oddstr13 oddstr13 mentioned this pull request May 31, 2019
@macbean101
Copy link

referred here from another (i guess the same?) issue. installed the supplied updated plugin and initially it didn't work. But after renaming my kodi config folder to start fresh, this started scanning without issue (so far).

@oddstr13 oddstr13 merged commit 24ffc88 into jellyfin:master Jun 2, 2019
@Gomez
Copy link

Gomez commented Jun 30, 2019

Confirmed. Current master works (https://github.com/jellyfin/jellyfin-kodi/archive/master.zip). But i had to reset my kodi too.

Is a reset really necessary?

@macbean101
Copy link

I just finalized my move from emby to jellyfin. This time, instead of resetting completely, i just created a new profile and made it my default. This way at least everything I needed was already downloaded and installed.

@Renaud11232
Copy link

Looks nice, any idea on when it will be released on the plugin repository ?

@oddstr13
Copy link
Member

oddstr13 commented Jul 9, 2019

I want to improve debug loging first, to make new issues easier to track down

@oddstr13 oddstr13 mentioned this pull request Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error during Jellyfin-Kodi sync Can't sync audio
6 participants