Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter keys containing None values from dictionaries returned from the server #366

Merged
merged 5 commits into from Aug 21, 2020
Merged

Filter keys containing None values from dictionaries returned from the server #366

merged 5 commits into from Aug 21, 2020

Conversation

oddstr13
Copy link
Member

This probably breaks something somewhere, needs proper testing before merge.

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2020 •
edited

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.5% 0.5% Duplication

@oddstr13
Copy link
Member Author

oddstr13 commented Aug 21, 2020 •
edited

I see no new errors on incremental sync against 10.6.3 in Kodi 19

@oddstr13 oddstr13 marked this pull request as ready for review August 21, 2020 18:48
mcarlton00
mcarlton00 approved these changes Aug 21, 2020
View reviewed changes
Copy link
Member

@mcarlton00 mcarlton00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sync and playback seem to work fine, no issues that I see

@mcarlton00 mcarlton00 merged commit 4e2c8a0 into jellyfin:master Aug 21, 2020
@oddstr13 oddstr13 mentioned this pull request Aug 25, 2020
Merged
@oddstr13 oddstr13 mentioned this pull request Sep 5, 2020
Closed
@oddstr13 oddstr13 mentioned this pull request Oct 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcarlton00 mcarlton00 mcarlton00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oddstr13 @mcarlton00