Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pipeline #367

Merged
merged 3 commits into from Aug 22, 2020
Merged

Refactor pipeline #367

merged 3 commits into from Aug 22, 2020

Conversation

mcarlton00
Copy link
Member

Hopefully fixing the artifact labels and downloading them

@mcarlton00 mcarlton00 changed the title Update azure artifact name Refactor pipeline Aug 22, 2020
@mcarlton00
Copy link
Member Author

Reworked the pipeline some more. Changes this time:

  • Gets triggered by all PRs and tags
  • Splits the publish tasks into their own file with the condition set on the top level
  • Change how the addons are published as artifacts to avoid double zipping them
  • Create a 'clean' copy of the addon that doesn't include unnecessary items (.git, .github, tests, etc)

@mcarlton00 mcarlton00 marked this pull request as ready for review August 22, 2020 02:48
@oddstr13
Copy link
Member

I'd prefer it if only git(hub)/ci files where ignored, and that testing/dev and related files be left in.
This would enable easier testing of a published release (whenever we get that far with unit testing)

@mcarlton00
Copy link
Member Author

Easy enough change, but I figured we'd be running the tests before building the zip. So I guess it all depends on which direction we want to go with that in the future

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@oddstr13
Copy link
Member

Well, yes, but I was thinking of the possibility for running tests after-the-fact, and possibly on a target system 😃

Copy link
Member

@oddstr13 oddstr13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't really matter either way tho, it's easy to change it in the future.

Let's see if this works! 🚀

@oddstr13 oddstr13 merged commit b89b9e0 into jellyfin:master Aug 22, 2020
@oddstr13 oddstr13 mentioned this pull request Aug 25, 2020
@mcarlton00 mcarlton00 deleted the artifact-name branch April 3, 2022 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants