Fix #539 "cast not available" #731
Conversation
Use jellyfin db to determine parent path id
This reverts commit 63d4081.
|
Apologies, I don't have time to review this for a while.
…On 6 May 2023 10.57.36 CEST, GregoireDruant ***@***.***> wrote:
Fixes the "cast not available" message when viewing tvshow or episode info in kodi, issue #539
Works with add-on mode and native mode as well.
The fix only consist in setting the mediatype and scrapper for each path entry in kodi database.
Normally only parent paths have this information, but jellyfin-kodi does not set parentPathIds.
Also I tryed setting the parentPathIds but this does not fix the "cast not available" message if the parent path is not a regular folder (does not work with plugin://).
You can view, comment on, or merge this pull request online at:
#731
-- Commit Summary --
* Feat: Set mediaType and scrapper to all paths for movies and tvshows
* Merge branch 'fix/cast-not-available-blunt-method'
-- File Changes --
M jellyfin_kodi/objects/kodi/queries.py (7)
-- Patch Links --
https://github.com/jellyfin/jellyfin-kodi/pull/731.patch
https://github.com/jellyfin/jellyfin-kodi/pull/731.diff
--
Reply to this email directly or view it on GitHub:
#731
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
|
…ot-available-mediaType-scrapper-parentTrail
|
Sorry there is an issue with this fix, regarding the information pannel for a tvshow episode.
If I remove the value "metadata.local" from the scrapper column, the info panel works again but without cast information. I know how to fix this in native mode but not sure I can fix it in add-on mode. Anyway I will commit a proper fix for native mode, that does not break anything in add-on mode. I will do so by setting the path trail from episode to top parent path and set the mediatype and scrapper to the top parent path only, as kodi does. |
Also do not set content and scrapper from path not being top paths
Does not seem to harm anything even if it does not fix the infos
|
This is the proper fix, works perfectly in native mode, but does not fix add-on mode. Regarding add-on mode, I neither use Plex nor PlexKodiConnect but I think the same approach could be used, especially since I found out that in add-on mode context menus act strange, even with the latest release of jellyfin-kodi. Not sure if I'll be able to check that this week, I will try when I have some time. |
Context menus are working again Still no cast information Issue with idParentPath to fix tvshow path to check
Hacky, to be tested
|
After a lot of time spent to search how to make every kodi menu work in addon mode - for tvshows, which are the only videos that was not working ok - , the only way I cloud achieve it is by creating a top path entry with strPath = "plugin://plugin.video.jellyfin/" and strContent = tvshows, scrapper = metadata.local. I found in the commits history that it used to be done like that but it was changed by Matt in in 2019, when he added the libraryId in the paths. I could not figure out why. I did not remove his changes but I re added the top path with the plugin address and it seems to be working fine now. So this PR includes fixes for both the add-on mode and native mode. |
|
I have been using this for 3 weeks both in native mode on a nvidia shield and in add-on mode on a windows pc, it has been working without issue. Beside @oddstr13, can anyone review this PR ? |
INSERT OR REPLACE does not work when null values are provided as part of the unique index
Which caused new videos not to be added to library on automatic update
|
I just added two new bugfixes to the music video library.
|
|
I (and the Jellyfin project) has a strong preference for smaller, easier to review PRs, so please create another PR for the unrelated changes 🙂 I'm done with school for the summer, so I'll hopefully have more time for this project going forward |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -71,6 +71,15 @@ | |||
| except TypeError: | |||
| return | |||
|
|
|||
| def get_episode_kodi_parent_path_id(self, *args): | |||
Check notice
Code scanning / CodeQL
Explicit returns mixed with implicit (fall through) returns Note
I just reverted these commits and created PR #742 |
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #731 +/- ##
==========================================
- Coverage 21.51% 21.50% -0.02%
==========================================
Files 63 63
Lines 8542 8575 +33
Branches 1572 1575 +3
==========================================
+ Hits 1838 1844 +6
- Misses 6680 6707 +27
Partials 24 24 ☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
oddstr13
added
enhancement
|
@mcarlton00 said in chat that this PR functionally is good to go, and I think the styling lints are fine as is, considering the fact that that's how the old code base has been doing it, and as such is present all over these files. |
Closes #539 "cast not available" message when viewing tvshow or episode info in kodi.
Works with add-on mode and native mode as well.
The fix only consist in setting the mediatype and scrapper for each path entry in kodi database.
Normally only parent paths have this information, but jellyfin-kodi does not set parentPathIds.
Also I tryed setting the parentPathIds but this does not fix the "cast not available" message if the parent path is not a regular folder (does not work with plugin://).