Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust settings to follow latest settings guidelines #1017

Merged
merged 9 commits into from
Apr 5, 2023
Merged

Adjust settings to follow latest settings guidelines #1017

merged 9 commits into from
Apr 5, 2023

Conversation

sevenrats
Copy link
Member

Changes
adjust some strings, honor ordering, use imperative and dont use parents name in playback settings

Issues

@cewert cewert added this to To do in Ongoing development Feb 24, 2023
@cewert cewert moved this from To do to In progress in Ongoing development Feb 24, 2023
@github-actions github-actions bot added the merge-conflict This PR has a merge conflict label Feb 25, 2023
@cewert cewert added this to In progress in next release Mar 17, 2023
@github-actions
Copy link

This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity.

@github-actions github-actions bot added the stale This issue/PR has gone stale. label Mar 19, 2023
@cewert
Copy link
Member

cewert commented Mar 19, 2023

Is this ready for review? If so, can you please merge your branch with the latest version of unstable and fix merge conflicts?

@github-actions github-actions bot removed the stale This issue/PR has gone stale. label Mar 20, 2023
@github-actions github-actions bot removed the merge-conflict This PR has a merge conflict label Mar 25, 2023
@sevenrats sevenrats changed the title adjust playback settings obey latest settings guidelines Mar 25, 2023
@sevenrats
Copy link
Member Author

@cewert yes. done.

cewert
cewert reviewed Mar 28, 2023
View reviewed changes
settings/settings.json Outdated Show resolved Hide resolved
cewert
cewert reviewed Mar 28, 2023
View reviewed changes
Copy link
Member

@cewert cewert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the two unresolved code reviews and we can get this merged 👍

@sevenrats sevenrats requested a review from cewert March 29, 2023 19:01
cewert
cewert approved these changes Mar 29, 2023
View reviewed changes
Copy link
Member

@cewert cewert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Ongoing development automation moved this from In progress to Reviewer approved Mar 29, 2023
@1hitsong 1hitsong merged commit d08b828 into jellyfin:unstable Apr 5, 2023
Ongoing development automation moved this from Reviewer approved to Done Apr 5, 2023
next release automation moved this from In progress to Done Apr 5, 2023
@1hitsong 1hitsong changed the title obey latest settings guidelines Adjust settings to follow latest settings guidelines Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1hitsong 1hitsong 1hitsong approved these changes

@cewert cewert cewert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Ongoing development
Done
next release
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sevenrats @cewert @1hitsong