Reset loop mode when user changes song #1165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cewert
reviewed
Apr 6, 2023
There was a problem hiding this comment.
Loop still works as expected when the last track ends. Single song loop still works as expected. Switching songs turns off single song loop 👍
I forgot to mention this in #1108 but spotify switches to playlist loop when switching songs while single song loop is toggled. Do you think we should do the same?
|
Oh, interesting. I vote no for now. In my mind single song loop and playlist loop are separate expected behaviors. |
cewert
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Resets audio player loop mode to default when user clicks to go forward or backward.
Issues
Fixes #1108