Add instant mix functionality to album screen #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
candry7731
reviewed
Jun 10, 2022
candry7731
reviewed
Jun 10, 2022
| url = Substitute("/Items/{0}/InstantMix", id) | ||
| resp = APIRequest(url, { | ||
| "UserId": get_setting("active_user"), | ||
| "Limit": 201 |
There was a problem hiding this comment.
Why 201? It takes a really long time for my server in the cloud to compile this instant mix. Maybe my network paths are congested tonight.
There was a problem hiding this comment.
The web client gathers a max of 200 songs for an Instant Mix. The methodology I use to get the proper ID will cause the 1st song on the album to always be the first song in the mix. I resolve this by requesting 201 and skipping the first song.
candry7731
approved these changes
Jun 10, 2022
jimdogx
approved these changes
Jun 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add Instant Mix button to album page. Clicking button will generate an instant mix based on the album and begin playing it for the user.
Issues
None. New functionality