Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Maximum Bitrates values based on Roku Guidelines #909

Merged
merged 1 commit into from
Dec 31, 2022

Conversation

ApexArray
Copy link
Contributor

@ApexArray ApexArray commented Dec 19, 2022

Changes
Set max bitrate for each codec profile according to Roku Supported video codecs

Issues
Fixes #722
Possibly fixes #401, #449, #496
Likely fixes the issues observed in #541. We could also set these limits from a user setting if desired.

@1hitsong 1hitsong merged commit aed4176 into jellyfin:unstable Dec 31, 2022
@1hitsong 1hitsong changed the title set maximum bitrates according to roku docs Set Maximum Bitrates values based on Roku Guidelines Dec 31, 2022
@NeuroDawg
Copy link

NeuroDawg commented Jan 5, 2023

Please don't start setting maximum bitrates based upon that Roku chart. As I mentioned in #944, this chart isn't accurate. I have no problems direct streaming (audio has to be transcoded) blu-ray remuxes from makemkv that are >20Mbps in h264 codec, using Jellyfin client on a Roku 4. I'd hate to see my files transcoded to a lower bitrate just because Jellyin thinks it can't play them.

@thegreatprophetzarquon
Copy link

thegreatprophetzarquon commented Feb 10, 2023

Yes, these limits don't seem accurate at all. I think that has to be for older models, perhaps for the the express stick, or just potentially very conservative. On my 2019 Roku Ultra, I've had Plex stream AVC bluray remuxes with no transcoding at around 40mbps with no issue and played at least one HVEC 4K UHD remux just fine (definitely over 40mbps). I'm very sure many official apps use higher bitrates than 10mbps for h264.

I just set up a Jellyfin sever and the 10mbps bitrate limit that's hardcoded right now is a deal breaker for using the Roku app. This looks terrible for many films: certainly anything with film grain.
The option to set/remove this limit (either in the client or from the server side) is most desirable, (#541) but absent that you should remove or raise this, at least for the moment.

@thegreatprophetzarquon
Copy link

thegreatprophetzarquon commented Feb 10, 2023

And I see #975 is giving the option to disable this, fantastic. (although I really don't think 10Mbps is a good default limit for AVC; that's not a real device limitation and should be set higher). All good, don't mind me. lol.

@ApexArray
Copy link
Contributor Author

Wow, so sorry for the issues that this has caused.

I was indeed developing and testing on an older Roku 4200X, and the bitrate limitation was the only thing that fixed my issue. Making this a user setting is definitely the right call.

@ApexArray ApexArray deleted the set-maximum-bitrates branch February 10, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suddenly incorrectly transcoding 4k x265 HEVC files on one TV H265 HDR video not playing
5 participants