Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Crash When Invalid Deep Link Arguments Are Passed #920

Merged
merged 7 commits into from
Dec 31, 2022

Conversation

ApexArray
Copy link
Contributor

For some reason, launching the channel via a RASP automation script sets this value to an empty string in stead of null, which was causing the channel to crash.

Changes
Fixes crash when args.contentId is set to an empty string.

Also replaces instances of <> invalid with isValid() within this function.

source/Main.brs Outdated Show resolved Hide resolved
source/Main.brs Show resolved Hide resolved
source/VideoPlayer.brs Outdated Show resolved Hide resolved
source/Main.brs Outdated Show resolved Hide resolved
source/utils/misc.brs Outdated Show resolved Hide resolved
@ApexArray
Copy link
Contributor Author

Tests:
image

@1hitsong 1hitsong merged commit e634227 into jellyfin:unstable Dec 31, 2022
@1hitsong 1hitsong changed the title Fix crash on empty contentId Fix Crash When Invalid Deep Link Arguments Are Passed Dec 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants