Don't crash when viewing in progress recording. #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1hitsong
requested changes
Jan 4, 2023
Co-authored-by: 1hitsong <3330318+1hitsong@users.noreply.github.com>
Co-authored-by: 1hitsong <3330318+1hitsong@users.noreply.github.com>
Co-authored-by: 1hitsong <3330318+1hitsong@users.noreply.github.com>
Co-authored-by: 1hitsong <3330318+1hitsong@users.noreply.github.com>
1hitsong
approved these changes
Jan 4, 2023
neilsb
approved these changes
Jan 5, 2023
|
@jimdogx - Is there a way for me to test this updated version of the Roku app now that you've implemented a fix? |
|
@numericOverflow if you feel comfortable with side loading apps on your Roku (it does not remove or alter your main installation), you can read up on it more here: https://github.com/jellyfin/jellyfin-roku/blob/unstable/DEVGUIDE.md Feel free to ask questions in the Matrix 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current version crashes when trying to view a recording in progress.
Changes
Defensive coding
Issues
Fixes #501